On my server, I can usually craft cards for around $2000/card and decks average for about 25k/deck (average selling price of all 4 decks) . The average profit per deck is around 9k gold, and I can process (on average) 9ish decks per hour. This means that the average gold generation rate of processing linen and herbs is about 80k gold per hour. That also leaves you with a massive pile of red pigments that you can AFK craft to scrolls for extra profit. (Crimson pigments gets generated at 75 pigment/min for "free" when milling for Viridescent, there is an extra 500ish gold per minute of profit when AFK-crafted to scrolls, that's not insignificant)
Professions have changed dramatically in Legion. While before you simply had to pay for recipes when you were in town, now the trainers as you to gather certain materials or defeat certain targets in order to unlock additional recipes. How can you profit from this new system? Well, to compensate players with the harder recipe unlocks, the developers have implemented a recipe rank system.
Gathering (Mining, Herbing, Skinning, Fishing) – WoD almost totally killed gathering with the garrison but it made a big comeback for Legion. I don’t think BfA will be any different. Crafters always need materials and they will pay big bucks for it. While the crafting professions might have bigger profit margins, gathering has always seemed to produce a nice steady income. Materials always sell and usually sell fast. One thing I am watching for BfA is old materials. With the change to how you level professions, gone are the days of power leveling a new toons profs using only WoD mats. On one hand you won’t need to in order to do the BfA stuff. On the other hand if enough folks still like finishing off the prior xpac stuff, old material prices could go up and low level gathering might be more profitable similar to how Ghost Iron is now.
-Bugs- There aren't too many glaring bugs anymore, but you will certainly encounter some. The pathetic thing is that many of the bugs you'll encounter were reported repeatedly during Alpha/Beta and still weren't fixed. Some bugs were discovered after release and players were able to abuse game mechanics without repercussion unless they were one of the more serious offenders. This gave some players a significant advantage over others because they used exploits and at the start of an expansion, that is the time when it's most impactful.
I'm aware that the LS chain can be xmuted up all the way up from GIO. This is great since it means ultimately you only need to track/acquire one item. The procs can certainly increase your profit margin, but as I said in my top-level comment the profitability of the whole endeavor is server-dependent. These numbers will of course vary from server to server, and for some it might be worth it.
Gold-making blog Just My Two Copper suggests that enchanting will be quite the money making profession during the initial phase of Patch 5.3. This is because with players racking up new shield heirloom items and new PvP weapons and cloaks, and the tendency of PvP fans to max out every potential stat in their gear to win their matches, they will spend a pretty penny on Enchanting boosts. Just My Two Copper expects direct enchanting fees as well as the costs of Enchanting materials to rise during the start of the patch.
Is there still the requirement to level previous expansions with the new system? TMK, old enchants don't sell fast. Unless the changes to leveling have caused old enchants to start selling (anything for a little more dmg and speed, right?)... For the health of the game I think this is a good change but I wonder why anyone would go back and level previous stuff, save goblins and completionist.
That's where i'm at now. I got into it late. I had 40k to start. Sold fish up to about 100k total starting capital. Started making and selling decks when they were going for 80-200k on my server. Morons have repeatedly undercut decks by 30-60k at a time even after the market has been reset (not by me) multiple times. Now the decks are 25-80k... I did manage to make 3.5m gross in the last 2 weeks. Now the individual cards are selling for MUCH less than the decks so I may stop crafting myself and just start buying the individuals... idk where to go from there though. Do you think the decks will hold any value moving forward? I'm kind of hoping for something similar to obliterum in legion to increase the ilvl and keep them relevant.